Skip benchmarks in ci when running in fork repositories #11737
Conversation
CodSpeed Performance ReportMerging #11737 will not alter performanceComparing Summary
|
psf-chronographer
bot
added
the
bot:chronographer:provided
Cycloctane
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
+ Coverage 98.72% 98.74% +0.02%
==========================================
Files 127 127
Lines 43754 43754
Branches 2328 2328
==========================================
+ Hits 43196 43205 +9
+ Misses 395 389 -6
+ Partials 163 160 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The preferred solution is storing the plain text token fore Codecov. As for codspeed, I haven't seen it failing. Do you have any examples? FWIW, the repo checks should be done through repo IDs. |
Cycloctane
changed the title
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
I wonder, though, if benchmarking could still run but just skip uploading the results, conditionally. Could you check?
@Cycloctane have you been able to check if this is possible? |
|
Sorry for the delay. I've checked codspeed docs. Benchmarking can be done separately with pytest-codespeed. But codspeed's github action does not to support skipping uploading. Codspeed token seems not necessary for public repository. We can safely remove it. |
|
pypy test is failing. Because pyo3 has dropped support for pypy3.10. |
webknjaz
force-pushed
the
skip-workflows-in-forks
branch
from
6eba1d0 to
947f356
Compare
Alright, this is blocked on CodSpeedHQ/action#146, then.
Sounds good. |
webknjaz
added
backport-3.13
| needs: | ||
| - build-tarball | ||
| - build-wheels | ||
| - pre-setup # transitive, for accessing settings | ||
| runs-on: ubuntu-latest | ||
| if: >- | ||
| needs.pre-setup.outputs.upstream-repository-id == github.repository_id |
There was a problem hiding this comment.
Could you move this to a separate PR?
There was a problem hiding this comment.
Ah, never mind. It's kinda related but the PR title+description+change note should reflect this.
| uses: CodSpeedHQ/action@v4 | ||
| with: | ||
| mode: instrumentation | ||
| token: ${{ secrets.CODSPEED_TOKEN }} |
There was a problem hiding this comment.
Aparrently, they've implemented OIDC two days ago. Perhaps, we could configure it as a part of replacing this token: https://codspeed.io/docs/integrations/ci/github-actions/configuration#oidc-recommended
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
webknjaz
force-pushed
the
skip-workflows-in-forks
branch
from
947f356 to
6dc6b3e
Compare
3 participants
What do these changes do?
Forks cannot use codspeed account, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This pr make unnecessary steps skip if triggered workflow is not in the main repository.
Are there changes in behavior for the user?
aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/folder